New user self-registration is disabled due to spam. For an account please email bugs-admin@lists.llvm.org with your e-mail address and full name.

Bug 40426 - Go bindings fail to compile on 32-bit ARM
Summary: Go bindings fail to compile on 32-bit ARM
Status: RESOLVED FIXED
Alias: None
Product: llgo
Classification: Unclassified
Component: All Bugs (show other bugs)
Version: unspecified
Hardware: Other Linux
: P release blocker
Assignee: Unassigned LLVM Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-23 08:51 PST by Ayke van Laethem
Modified: 2019-02-17 12:17 PST (History)
3 users (show)

See Also:
Fixed By Commit(s):


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ayke van Laethem 2019-01-23 08:51:55 PST
The Go bindings for LLVM fail to compile on a 32-bit ARM system (Raspberry Pi 3 with 32-bit Linux kernel).
On this system, the Go compiler (version 1.11) disallows [1 << 30] with an error like the following:

    type [1073741824]_Ctype_uint larger than address space

The number of indices should never be this big anyway so can be lowered to (for example) 1 << 16, even 1 << 8 is probably more than enough for all use cases (it's the number of indices, not the range of them).

Note: I'm afraid I introduced this bug myself in https://reviews.llvm.org/D53883. I can write a fix if needed, even though fixing it is trivial.
I marked it as release-blocker as it is a clear regression, please set it as a normal bug if that is wrong.


Offending line:
https://github.com/llvm-mirror/llvm/commit/2c000da033ca03bf8ac5aa1c1b8a5fd5bcc5ecf5#diff-bc833bc845e04ff2763e528b30c5c900R1266
Comment 1 Kristof Beyls 2019-01-25 01:07:25 PST
Hi Ayke,

I expect that the 8.0 release will go ahead without this being fixed if no-one provides a fix in time. I'm not sure about the exact release timeline, but expect not too much time may be available anymore.
Therefore, I expect that it will have highest likelihood to be fixed in the 8.0 release if you'd try to provide a fix as soon as possible.
I expect the fix to need to first go in to trunk, and then to be merged back to the release branch. For documentation on the process to merge back fixes from trunk to a release branch, please see https://llvm.org/docs/HowToReleaseLLVM.html#merge-requests
Comment 2 Ayke van Laethem 2019-02-11 01:58:46 PST
@Kristof thank you for the explanation. I have provided a fix in this revision: https://reviews.llvm.org/D58030
Comment 3 Ayke van Laethem 2019-02-17 12:17:37 PST
Fix merged in https://reviews.llvm.org/rL354207.