New user self-registration is disabled due to spam. For an account please email bugs-admin@lists.llvm.org with your e-mail address and full name.

Bug 42670 - Extract variable and class layout code actions are noisy
Summary: Extract variable and class layout code actions are noisy
Status: RESOLVED FIXED
Alias: None
Product: clang-tools-extra
Classification: Unclassified
Component: clangd (show other bugs)
Version: unspecified
Hardware: PC Linux
: P enhancement
Assignee: Sam McCall
URL:
Keywords:
Depends on:
Blocks: release-9.0.0
  Show dependency tree
 
Reported: 2019-07-18 07:41 PDT by Sam McCall
Modified: 2019-07-22 11:08 PDT (History)
2 users (show)

See Also:
Fixed By Commit(s): r366443, r366451


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam McCall 2019-07-18 07:41:35 PDT
To mitigate this for the 9 release:
- Extract variable should trigger only with a nonempty selection
- class layout should be hidden behind a flag entirely
Comment 1 Sam McCall 2019-07-18 08:39:51 PDT
Hans, both fixes are non-invasive and should be good to merge. (Basically just disabling features)

Sorry for missing the cut
Comment 2 Hans Wennborg 2019-07-22 11:08:18 PDT
Merged r366443 in r366713
and r366451 in r366714.